Datasource+ table fetching API #10659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me fetching for postgres.
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## develop #10659 +/- ##
===========================================
+ Coverage 69.48% 69.57% +0.08%
===========================================
Files 536 536
Lines 19737 19775 +38
Branches 3914 3917 +3
===========================================
+ Hits 13714 13758 +44
+ Misses 5583 5581 -2
+ Partials 440 436 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Rory-Powell
reviewed
May 23, 2023
Rory-Powell
reviewed
May 23, 2023
Rory-Powell
reviewed
May 23, 2023
…-all-worksheets-when Fetch table names from google datasource
adrinr
reviewed
May 23, 2023
adrinr
approved these changes
May 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This introduces a new API endpoint for datasource+ types, which allows retrieving the list of tables which are available within the datasource.
This does not attempt to retrieve any information about the schema of each of the tables, as this is strictly for determining which tables are of interest - we should not retrieve any information beyond what is required to confirm with the user the tables they need.
I've also introduced a new feature flag which can be used for determining whether or not the datasource supports the table fetching feature - this can be assumed for all datasource+ databases, but this could change in future (some DS+ might not be able to do this).
I've also added some more test cases for this, using the new API endpoint
GET /api/datasources/:datasourceId/tablesas well as some basic test cases for the connection verification API/api/datasources/verify- these will run as part of CI against Postgres.